Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform #5286

Merged
merged 2 commits into from
May 22, 2024
Merged

HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform #5286

merged 2 commits into from
May 22, 2024

Conversation

wchevreuil
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
_ Other Tests _
1m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5286
Optional Tests
uname Linux 140b3979593e 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d9757c7
Max. process+thread count 40 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
_ Other Tests _
1m 24s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5286
Optional Tests
uname Linux 3a5472d7dee9 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d9757c7
Max. process+thread count 33 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 spotless 0m 56s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 5s Maven dependency ordering for patch
-1 ❌ hadolint 0m 0s The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌ spotless 0m 6s patch has 17 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
3m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5286
Optional Tests dupname asflicense spotless hadolint shellcheck shelldocs markdownlint
uname Linux 2a492cf31d59 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d9757c7
hadolint https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-general-check/output/diff-patch-hadolint.txt
whitespace https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-general-check/output/whitespace-eol.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 43 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/console
versions git=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Jun 14, 2023

What if we just change the original dockerfile? It will break normal x86 or arm platform?

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
_ Other Tests _
1m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5286
Optional Tests
uname Linux 86e52380b30c 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 68da890
Max. process+thread count 32 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
_ Other Tests _
2m 8s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5286
Optional Tests
uname Linux 83b3f2d29f31 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 68da890
Max. process+thread count 38 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
-1 ❌ hadolint 0m 0s The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌ spotless 0m 5s patch has 17 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
2m 38s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5286
Optional Tests dupname asflicense spotless hadolint shellcheck shelldocs markdownlint
uname Linux 54a29a480721 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 68da890
hadolint https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-general-check/output/diff-patch-hadolint.txt
whitespace https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-general-check/output/whitespace-eol.txt
spotless https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 43 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/console
versions git=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Jun 30, 2023

Any updates here?

@Apache9
Copy link
Contributor

Apache9 commented Aug 15, 2023

Ping @wchevreuil

taklwu
taklwu approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@taklwu taklwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all a sudden I upgraded my laptop and found this ....PR and fixed my issue, so +1

dev-support/hbase_docker/m1/Dockerfile
# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=linux/amd64 ubuntu:22.04 AS base_image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--platform=linux/amd64 should be the only change, so it looks good to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right way to do things. Instead, you should provide --platform to the docker command line invocation when building the image. That will cause it to pull down the ubuntu image of the specified platform.

I left a comment on the Jira with an example of how to do a multi-platform docker image. It's not the only way to do it, but it's the style I've been using in the kustomize repo. Yetus project may have an alternative example of how to achieve this.

@taklwu
Copy link
Contributor

taklwu commented May 22, 2024

@wchevreuil maybe you can fix the style issue?

@wchevreuil
spotless
ce5f3e7 
Change-Id: Ie12bfd25d8fc6ab314cf4f43bf8a5fc4b855c0e4
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
_ Other Tests _
1m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5286
Optional Tests
uname Linux 0dfc7575fae2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 419666b
Max. process+thread count 41 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 5s Maven dependency ordering for patch
_ Other Tests _
1m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5286
Optional Tests
uname Linux e009e7314e2d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 419666b
Max. process+thread count 28 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 45s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
_ Other Tests _
2m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5286
Optional Tests
uname Linux 7350ef9aa276 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 419666b
Max. process+thread count 40 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 5s Maven dependency ordering for patch
-1 ❌ hadolint 0m 0s The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 39s patch has no errors when running spotless:check.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
3m 3s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5286
Optional Tests dupname asflicense spotless hadolint shellcheck shelldocs markdownlint
uname Linux 45f86b8f90b2 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 419666b
hadolint https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-general-check/output/diff-patch-hadolint.txt
Max. process+thread count 46 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/console
versions git=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil wchevreuil merged commit e5b5816 into apache:master May 22, 2024
1 check failed
wchevreuil added a commit that referenced this pull request May 22, 2024
@wchevreuil
HBASE-27915 Update hbase_docker with an extra Dockerfile compatible w…
8fe7237 
…ith mac m1 platform (#5286)

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
wchevreuil added a commit that referenced this pull request May 22, 2024
@wchevreuil
HBASE-27915 Update hbase_docker with an extra Dockerfile compatible w…
1705d7b 
…ith mac m1 platform (#5286)

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
wchevreuil added a commit that referenced this pull request May 22, 2024
@wchevreuil
HBASE-27915 Update hbase_docker with an extra Dockerfile compatible w…
f8f8555 
…ith mac m1 platform (#5286)

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
wchevreuil added a commit that referenced this pull request May 22, 2024
@wchevreuil
HBASE-27915 Update hbase_docker with an extra Dockerfile compatible w…
b61a73a 
…ith mac m1 platform (#5286)

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
wchevreuil added a commit that referenced this pull request May 22, 2024
@wchevreuil
HBASE-27915 Update hbase_docker with an extra Dockerfile compatible w…
6cfb809 
…ith mac m1 platform (#5286)

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk left review comments

@taklwu taklwu taklwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wchevreuil @Apache-HBase @Apache9 @taklwu @ndimiduk